Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to dynamically load contexts #5409

Merged
merged 1 commit into from Feb 28, 2019

Conversation

Projects
None yet
3 participants
@hansdubois
Copy link
Contributor

commented Feb 26, 2019

This PR will add the possibility to dynamically load context for Gherkin tests. When using the suggested method of adding contexts to your codeception.yml file. This soon will become a long list of context files and quite a pain to maintain.

By adding the following line to configuration contexts will automatically be loaded:

gherkin:
    contexts:
        path: tests/_support/Steps
        namespace_prefix: Steps
        default:
            - AcceptanceTester

Unfortunately this cannot be solved via a Customer loader, because the GherkinSnippet class directly instantiates the Gherkin loader instead of the specified Gherkin loader. Something that could be fixed but with a lot more work.

@hansdubois hansdubois force-pushed the hansdubois:2.5 branch 3 times, most recently from 12091c5 to e14b06e Feb 26, 2019

@hansdubois hansdubois force-pushed the hansdubois:2.5 branch from e14b06e to b70cb71 Feb 26, 2019

@DavertMik

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Thanks, looks good to me!
I will merge it as it should not break anything

@DavertMik DavertMik merged commit f945662 into Codeception:2.5 Feb 28, 2019

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
wercker/build Wercker pipeline passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.