Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid removing required fields in cookies. #5470

Merged

Conversation

Projects
None yet
3 participants
@JorisVanEijden
Copy link
Contributor

commented Apr 16, 2019

A cookie with ['name' => 'test', 'value' => 0] would get it's value stripped, causing an "undefined index: value" notice in php-webdriver's Cookie.php

@DavertMik

This comment has been minimized.

Copy link
Member

commented Apr 21, 2019

Thanks!

@DavertMik DavertMik merged commit 2b17a54 into Codeception:2.5 Apr 21, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@JorisVanEijden JorisVanEijden deleted the JorisVanEijden:missing-empty-cookie-values branch Apr 23, 2019

DavertMik added a commit that referenced this pull request Apr 23, 2019

Merge 2.5 to 3.0 (#5479)
* Proposed solution for #5457 gherkin scenarios not loaded from group file (#5458)

* proposed solution for #5457 gherkin scenarios not loaded from group file

* testing for getMetaData method before calling it in GroupManager

* reformatting if statement to appease nitpick

* adding tests for #5457

* Update LOCAL_FILE constant for new version of phpseclib (#5461)

* Using button formaction attr in proceedSubmitForm method (#5440)

* Using button formaction attr in proceedSubmitForm method (AcceptanceTesterActions::submitForm)

* Update InnerBrowser.php

* Avoid removing required fields in cookies. (#5470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.