Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support initial queries execution after creating connection #5660

Merged
merged 6 commits into from Aug 24, 2019

Conversation

@tadasauciunas
Copy link
Contributor

commented Aug 21, 2019

Fixes #5612
Fixes #5605
Replaces #5614

sync
3.0
@tadasauciunas

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

This includes changes discussed in #5614

@Naktibalda Naktibalda changed the base branch from 3.0 to 3.1 Aug 22, 2019
Copy link
Member

left a comment

Looks good to me.
Please document this setting in the large docblock at the top of this file.
It would be good to include some motivation when it is useful and provide an example.

@Naktibalda Naktibalda requested a review from DavertMik Aug 22, 2019
Copy link
Member

left a comment

Looks good now.

@DavertMik

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Seems good to me!

@Naktibalda Naktibalda merged commit f2e6ac8 into Codeception:3.1 Aug 24, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.