Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doctrine2] Make debug message in haveInRepository support entities with composite keys of entities in bidirectional relations #5685

Merged
merged 3 commits into from Sep 13, 2019

Conversation

@Basster
Copy link
Contributor

commented Sep 12, 2019

Fixes #5663.

Other than in #5664, I only fixed the debug message creation for entities with composite keys of entities in bidirectional ManyToOne relations.

@DavertMik

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

Thanks!

@DavertMik DavertMik merged commit 9889794 into Codeception:3.1 Sep 13, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@Basster Basster deleted the Basster:debug-have-in-repository-pks branch Sep 13, 2019
@Naktibalda

This comment has been minimized.

Basster added a commit to Basster/Codeception that referenced this pull request Sep 23, 2019
…uid on the haveInRepository debug message.
Naktibalda added a commit that referenced this pull request Oct 10, 2019
…ebug message. (#5692)

* #5685: support non-entity doctrine @id, e.g. Ramsey\Uuid\Uuid on the haveInRepository debug message.

* missing line indention.

* check for uuid type first

* catch correct MappingException.

* Revert "catch correct MappingException."

This reverts commit d3d4daf

* catch both of doctrines MappingExceptions, since they don't share a common base exception. Catching \Exception here would be too vague.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.