Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recorder filename with special chars #5846

Merged
merged 1 commit into from Feb 19, 2020
Merged

Conversation

gimler
Copy link
Contributor

@gimler gimler commented Feb 13, 2020

When you have special chars in your scenario titles the recorder can't create the directory.

example Scenario: Simple Login/Logout

@gimler
Copy link
Contributor Author

@gimler gimler commented Feb 13, 2020

travis fails are third party dependency problems not related to my change

@Naktibalda
Copy link
Member

@Naktibalda Naktibalda commented Feb 16, 2020

travis fails are third party dependency problems not related to my change

Codeception 3.1 is no longer maintained, I can only merge this change to 4.0 branch.

@Naktibalda Naktibalda changed the base branch from 3.1 to 4.0 Feb 16, 2020
@Naktibalda Naktibalda merged commit 7c67722 into Codeception:4.0 Feb 19, 2020
1 of 2 checks passed
@Naktibalda
Copy link
Member

@Naktibalda Naktibalda commented Feb 19, 2020

Released as 4.1.1

@gimler gimler deleted the patch-2 branch Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants