Do not truncate arguments for --html options #5870
Conversation
By running the `run --html`, we can have a report.html file that is generated. However, the content of this file is truncated, thus making the report sometimes unusable. This is a quick proposal but IMO it should not be merged as it is. We should rather create an optional conf input (or whatever) to let the user chose if yes or not, he wants the truncate to happen, and how maximal characters he desires.
|
This change looks good to me (I can't find anything that could be broken by it). We have a few tests for HTML reports in https://github.com/Codeception/Codeception/blob/4.0/tests/cli/RunCest.php , so if you could add one for this case, it would be less likely that you change will be reverted in the future. |
|
@Naktibalda I've just added an unit test since it seems to be enough. I tried to refactor a bit since this is quite a mess, but after a shot I gave up since it would have take too long for me right now. |
|
I merged your change to 4.0 branch: cb476ea Thank you for this contribution. |
|
Released in 4.1.2 |
By running the
run --html, we can have a report.html file that is generated.However, the content of this file is truncated, thus making the report sometimes unusable.
This is a quick proposal but IMO it should not be merged as it is.
We should rather create an optional conf input (or whatever) to let the user chose if yes or not, he wants the truncate to happen, and how maximal characters he desires.
Fixes #5869