Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize WebDriver module for issue #518, clear some typo by my previous commit, and add 'moveMouseOver' function #591

Merged
merged 1 commit into from Oct 6, 2013

Conversation

Projects
None yet
2 participants
@wyhmichael
Copy link
Contributor

commented Oct 4, 2013

I changed this class in order that _before is responsible for setup and _after / _afterSuite() are responsible for cleanup, changes made by me include:

  • removed register_shutdown_function in _initialize to prevent uncertainties
  • removed $this->webDriver->manage()->deleteAllCookies(); in _before, if user wants to keep the same session between tests, he/she is the one to take care how tests work, this can be achieved by making helper class
  • changed _after class, currently it only does something when user choose to restart session
  • changed _afterSuite() to make sure webDriver object cleared after suite done
  • added 'moveMouseOver' method
  • corrected some typo from my previous commit
Michael Wang Michael Wang
optimize WebDriver module for issue #518, clear some typo by my previ…
…ous commit, and add 'moveMouseOver' function
@DavertMik

This comment has been minimized.

Copy link
Member

commented Oct 6, 2013

Thanks. Good job!
That's nice to see how WebDriver module becomes better and better.

DavertMik added a commit that referenced this pull request Oct 6, 2013

Merge pull request #591 from wyhmichael/master
optimize WebDriver module for issue #518, clear some typo by my previous commit, and add 'moveMouseOver' function

@DavertMik DavertMik merged commit 80ffe3e into Codeception:master Oct 6, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.