detect the suite from a test path relative to the current working dir #6051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrl-f5
force-pushed
the
match-single-test-path
branch
3 times, most recently
from
b88d3a9 to
1040c00
Compare
Member
|
@Naktibalda worth merging master into this one and checking test results with GitHub actions. |
ctrl-f5
force-pushed
the
match-single-test-path
branch
from
1040c00 to
a5dc57d
Compare
Contributor
Author
|
@samdark updated with upstream, seems to run fine in the new actions setup! |
Member
|
It doesn't break current tests. That's good. It would be great to add some tests verifying the change. |
Contributor
Author
|
It was basically already tested by |
ctrl-f5
force-pushed
the
match-single-test-path
branch
from
f01b3d7 to
e480660
Compare
Naktibalda
reviewed
Dec 27, 2020
Member
Member
|
I implemented patch, which will make your change to apply only if relative path is inside tests directory #6105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect the suite from a test file or path relative to the current working directory.
This fixes the issue that the suite cant be detected when
codeception.ymlis in any subdirectory, and subsequently also fixes the issue when it's inside the tests directory, for which there was a single use case fix in place.