Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion on missing modules #6079

Merged

Conversation

c33s
Copy link
Contributor

@c33s c33s commented Jan 10, 2021

had the problem that i wasn't able to connect to a module, which i included in the config. took quite a while to debug. it was a simple diff in the case LockPick vs Lockpick

so i added some code to add a suggestion which module could be meant to the error message.

[ModuleException] Codeception\Module: Module \C33s\Codeception\Module\LockPick couldn't be connected 

vs

[ModuleException] Codeception\Module: Module \C33s\Codeception\Module\LockPick couldn't be connected (did you mean '\C33s\Codeception\Module\Lockpick'?)

have not adapted any tests yet, wanted to wait for comments if you would merge this before.

@DavertMik
Copy link
Member

DavertMik commented Jan 11, 2021

This looks really nice to me! Thank you 👍
This UX fix will save my time as well 😃

Yes, please add some tests into ModuleContainerTest

@c33s c33s changed the title RFC: suggestion on missing modules suggestion on missing modules Jan 11, 2021
@c33s
Copy link
Contributor Author

c33s commented Jan 11, 2021

@DavertMik ready to merge.
can you squash the commits via the github interface or do i have to do it (only used to gitlab, there it's possible to squash on merge)?

@Naktibalda Naktibalda merged commit f1e1daa into Codeception:4.1 Jan 17, 2021
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants