Skip to content

Conversation

@marcovtwout
Copy link
Contributor

Fixes #1485

Please check and test this workaround thoroughly.

@Naktibalda
Copy link
Member

Wouldn't it be better to catch exception thrown by grabCookie?

@marcovtwout
Copy link
Contributor Author

@Naktibalda It's actually not grabCookie() that throws the exception. Calling grabCookie() (which internally calls WebDriver->manage()->getCookies()) unexpectedly dismisses the alert and execution continues. Then the next call in your acceptance tests such as $I->acceptPopup() will fail since the alert is no longer present.

@Naktibalda Naktibalda merged commit 91d6cb0 into Codeception:4.1 May 28, 2021
@marcovtwout marcovtwout deleted the fix-1485 branch May 31, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

acceptPopup doesn't work when using CodeCoverage

2 participants