Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wildcard matching of group files #6302

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Fixed wildcard matching of group files #6302

merged 2 commits into from
Dec 22, 2021

Conversation

DavertMik
Copy link
Member

Replaces #6300

This fixes using group manager to import groups from files by wildcard pattern.

#insude codeception.yml
groups:
    group_*: tests/_data/group_*

Previous behavior: tests/_data/group_* pattern found only files group_1, group_2, but NOT group_awesome, group_1_1 etc.

This behavior was incorrect as it didn't match all from a wildcard and limited results to group_\d+

Current behavior: tests/_data/group_* pattern finds all group* files in directory: group_1, group_1_1, etc

@DavertMik DavertMik mentioned this pull request Dec 21, 2021
Closed
DanielHansmannAldi added a commit to DanielHansmannAldi/Codeception that referenced this pull request Dec 21, 2021
@DanielHansmannAldi
Add test from Codeception#6302
08d3edb
@DanielHansmannAldi
Copy link

Thank you very much @DavertMik

TavoNiievez
TavoNiievez approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@TavoNiievez TavoNiievez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Naktibalda Naktibalda merged commit c873087 into 4.1 Dec 22, 2021
@Naktibalda Naktibalda deleted the fix-wildcard-group-match branch December 22, 2021 06:37
@Naktibalda
Copy link
Member

Released as 4.1.27

@Naktibalda Naktibalda mentioned this pull request Apr 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TavoNiievez TavoNiievez TavoNiievez approved these changes

@Naktibalda Naktibalda Naktibalda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavertMik @DanielHansmannAldi @Naktibalda @TavoNiievez