Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dry-run work with module methods having return types #6470

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

Naktibalda
Copy link
Member

Closes #6463

Copy link
Member

@TavoNiievez TavoNiievez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ask for my review when you go to integrate to the 5.0 branch, I have a couple of suggestions for typing

@Naktibalda
Copy link
Member Author

Now I think that it would be better to mock all methods of all modules to return correct types.

The main problem is that methods implemented in Tester classes are not steps, so they won't be mocked and they will call methods of real modules.

@Naktibalda
Copy link
Member Author

I updated code to mock all modules method, so dry-run works as before, but methods return correct types.

@Naktibalda Naktibalda merged commit 49b06ae into 4.2 Jun 16, 2022
@Naktibalda Naktibalda deleted the fix-dry-run branch June 16, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants