Skip to content

Conversation

@W0rma
Copy link
Contributor

@W0rma W0rma commented Nov 28, 2025

No description provided.

Comment on lines +1057 to 1058
$identifier = $form->attr('id') ?: $form->attr('action') ?? '';
if (!isset($this->forms[$identifier])) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lower PHP versions already converted null array keys to an empty string (https://3v4l.org/5UbfM) implicitly.

However, using null is deprecated in PHP 8.5.
That's why an empty string is used explicitly.

@W0rma
Copy link
Contributor Author

W0rma commented Nov 28, 2025

@TavoNiievez FYI

@TavoNiievez
Copy link
Member

@W0rma If you wish, I can arrange with the team to give you merge permissions on certain repositories, and instead, we can change our workflow so that you request code reviews from me when you deem it necessary, as well as release tags.

@W0rma
Copy link
Contributor Author

W0rma commented Nov 28, 2025

@W0rma If you wish, I can arrange with the team to give you merge permissions on certain repositories, and instead, we can change our workflow so that you request code reviews from me when you deem it necessary, as well as release tags.

Sure, that'd be great 👍

@TavoNiievez TavoNiievez merged commit 7c4f2c0 into Codeception:master Nov 28, 2025
5 checks passed
@TavoNiievez
Copy link
Member

@W0rma W0rma deleted the php85 branch November 28, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants