Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on laminas/laminas-console #13

Merged
merged 3 commits into from Jul 23, 2021

Conversation

javabudd
Copy link
Contributor

@javabudd javabudd commented Jul 6, 2021

References #12 and removes the dependency on laminas/laminas-console. A class_exists check is still happening in \Codeception\Module\Laminas line 98, which should preserve functionality for older clients.

A major version is recommended for this PR, as we are dropping support for PHP < 7.3

@TavoNiievez TavoNiievez linked an issue Jul 11, 2021 that may be closed by this pull request
@TavoNiievez
Copy link
Member

@javabudd php 7.3 is supported until December of this year. Can you please assign PHP 7.3 as a minimum?

@javabudd
Copy link
Contributor Author

@TavoNiievez Support for 7.3 has been added back

@TavoNiievez TavoNiievez merged commit 1f30e96 into Codeception:master Jul 23, 2021
@TavoNiievez
Copy link
Member

Thanks @javabudd
I need to adapt and merge #11 before tagging a new release. I will try to do it this weekend.

@javabudd
Copy link
Contributor Author

javabudd commented Oct 4, 2021

@TavoNiievez any updates on a new tag for this?

@TavoNiievez
Copy link
Member

@javabudd I released this as version 1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on laminas/laminas-console
2 participants