Allow more parameters to be sent to Predis Client #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a case where I needed to provide a password to connect to Redis and the current code did not allow it. Since everything from the Suite configuration goes to the this->config array, we can simply provide it and allow the user to set the password property This will also allow for other specific configurations
|
Please document usage of other parameters in the docblock above the class. |
|
I also need these parameters to pass username and password |
I added the full config to Predis' client, so the developer can pass username/password and/or other options. This commit adds some description above.
|
@Naktibalda done |
|
I released new version 1.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a case where I needed to provide a password to connect to Redis and the current code did not allow it.
Since everything from the Suite configuration goes to the this->config array, we can simply provide it and allow the user to set the password property
This will also allow for other specific configurations