Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JsonArray.php #37

Merged
merged 2 commits into from Nov 4, 2020
Merged

Update JsonArray.php #37

merged 2 commits into from Nov 4, 2020

Conversation

SoftCreatR
Copy link
Contributor

Resolves #24 (comment)

@ghost ghost mentioned this pull request Nov 4, 2020
Closed
@ghost
Copy link

ghost commented Nov 4, 2020

This should fix #38

@ghost
Copy link

ghost commented Nov 4, 2020

This should fix #38

Can confirm that this PR fixes this issue in our test suite. Still trying to figure out the rest of the problems ;)

@SoftCreatR
Copy link
Contributor Author

There are no other issues.

@Naktibalda Naktibalda merged commit beeb5a9 into Codeception:master Nov 4, 2020
@Naktibalda
Copy link
Member

Released as 1.2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexk984 alexk984 alexk984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abandoned dependency
3 participants
@SoftCreatR @Naktibalda @alexk984