Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added grabCollector function #47

Merged
merged 1 commit into from Nov 20, 2020
Merged

Added grabCollector function #47

merged 1 commit into from Nov 20, 2020

Conversation

TavoNiievez
Copy link
Member

TL:DR: I have ready PRs that will make use of this function. It is for internal use only. Some functions are present in the Laravel module and need symfony collectors. This will avoid repeating validation code like in #44.

Clic to see full description
I'm writing at least 4 functions related to form errors that are already available in the Laravel module: - seeFormHasErrors() - dontSeeFormErrors() - seeFormErrorMessages() - seeFormErrorMessage()

And others totally new functions like:

  • dontSeeMissingTranslations();
  • seeEventWasTriggered();
  • dontSeeDeprecations();

Since all these functions will need their respective collectors of the Symfony Profiler, it is necessary to have a function that validates that it exists and fails the test otherwise,

With grabCollector i avoid repeating code and having to optimize it later as in #44 .
This function is intended only for internal use. with protected access to be consistent with the other methods of the module.

I'll start sending the PRs of the functions I mentioned as soon as this gets merged to master, since the tests will fail before then.

@TavoNiievez TavoNiievez merged commit 68311dd into Codeception:master Nov 20, 2020
@TavoNiievez TavoNiievez deleted the grabCollector branch November 20, 2020 15:47
@TavoNiievez TavoNiievez added this to the 1.4.0 milestone Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant