Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installing on PHP 8 #18

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Allow installing on PHP 8 #18

merged 1 commit into from
Dec 20, 2020

Conversation

samdark
Copy link
Collaborator

@samdark samdark commented Nov 16, 2020

See #17

@samdark samdark added the enhancement New feature or request label Nov 16, 2020
@samdark
Copy link
Collaborator Author

samdark commented Nov 16, 2020

Related: Codeception/Codeception#6032

@samdark
Copy link
Collaborator Author

samdark commented Dec 16, 2020

@Timyipstudio can't merge yet because Codeception itself is not ready.

@Naktibalda
Copy link
Member

This pull request depends on Codeception/Codeception#6057 being merged.

Also I had to change codeception/verify version constraint in yii2-tests to '<2', because v2 implemented some breaking changes: https://github.com/Codeception/Verify/blob/master/UPGRADE.md

@@ -37,7 +37,7 @@ jobs:
run: |
composer require --no-update codeception/module-asserts
composer require --no-update codeception/module-filesystem
composer require --no-update codeception/codeception
composer require --no-update "codeception/codeception:dev-gherkin-fix-namespaced-contexts as 4.9.9"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be changed before merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed that commit.

@samdark
Copy link
Collaborator Author

samdark commented Dec 20, 2020

Awesome! Thanks.

This was referenced Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants