Skip to content
This repository was archived by the owner on Oct 25, 2021. It is now read-only.

Bugfix for attributes issue.#5

Closed
BrianHenryIE wants to merge 2 commits into
Codeinwp:masterfrom
BrianHenryIE:master
Closed

Bugfix for attributes issue.#5
BrianHenryIE wants to merge 2 commits into
Codeinwp:masterfrom
BrianHenryIE:master

Conversation

@BrianHenryIE
Copy link
Copy Markdown

I haven't done any Gutenberg programming before, so consider how this might affect other blocks. I should be fine. It certainly fixes the bug.

@HardeepAsrani
Copy link
Copy Markdown
Member

Hey @BrianHenryIE

Thank you for the PR. We don't manage the library in this git, but as a separate package altogether, so I'll close this PR and use the code in the original repository.

Would it be fine if I commit the code to another repository? If you want you can do it to the following repositories:

We want to release this sooner than later, so let me know if you will be able to send the PR today to the development branch of the mentioned repositories.

You can put the code in class-gutenberg-[css/animation].php file. Let me know if you're up for that. :)

@BrianHenryIE
Copy link
Copy Markdown
Author

I've made those PRs... untested!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants