-
Notifications
You must be signed in to change notification settings - Fork 12
feat: add offloads metrics with optional shortcuts #970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new "Offloaded images" metric box to the Optimole dashboard, allowing users to view the count of images offloaded to the cloud and providing easy access to manage image offloading settings.
- Added new metric card showing offloaded images count with management button
- Enhanced existing metric cards with action buttons for quick navigation
- Added localized strings for the new metric and button labels
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| inc/admin.php | Added localized strings for the new offloaded images metric and action buttons |
| assets/src/dashboard/parts/connected/dashboard/index.js | Added offloaded images metric card, action buttons for all metrics, and navigation logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
c75e05b to
d645628
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
assets/src/dashboard/parts/connected/dashboard/index.js:105
- The property
offload_imageis not defined in thesettingsTabobject. This will cause the navigation function to receiveundefinedwhen the offload images button is clicked.
value: () => navigate( settingsTab.offload_image )
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
2f31604 to
ca57c50
Compare
d85213e to
f5dbd96
Compare
f7b0281 to
9e1d87b
Compare
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Pro Plan with Offloading
Free user
Other information: