-
Notifications
You must be signed in to change notification settings - Fork 12
refactor: default settings for compression #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors default settings for compression in Optimole to improve handling of retina images and AVIF format options. The changes modify how DPR (Device Pixel Ratio) is applied and update the user interface to reflect better default behaviors.
- Automatically applies DPR for retina-enabled images or small images under 150px
- Changes speed-optimized compression to enable best format selection by default
- Conditionally displays AVIF settings based on a feature flag
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| inc/url_replacer.php | Adds automatic DPR logic for retina images and small images |
| inc/admin.php | Updates localization with AVIF feature flag and improved descriptions |
| assets/src/dashboard/parts/connected/settings/Compression.js | Enables best format by default for speed optimization and conditionally shows AVIF settings |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@Soare-Robert-Daniel, from what I understand from "On a fresh new install with the wp plugin, when connecting the plugin, the best format should be on and active.", this option "Automatic Best Image Format Selection" should be enabled by default https://vertis.d.pr/i/vBJErc and the images should have |
bd757a9 to
b08acd8
Compare
|
@rodica-andronache, you can check again for the Here is an example: https://defaults.vertisite.cloud/hello-world/
|
|
it's working well |
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |

All Submissions:
Changes proposed in this Pull Request:
Closes https://github.com/Codeinwp/optimole-service/issues/1513
Other information: