New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes due to accessibility issues: missing labels, text inside links... #408

Merged
merged 1 commit into from Oct 1, 2016

Conversation

Projects
None yet
2 participants
@felixzapata
Contributor

felixzapata commented Sep 10, 2016

I´ve uploaded some changes due to accessibility issues:

  • add text inside social links.
  • add focus to see our team information when you use the tab key.
  • modify read more links inside latest news.
  • modify background colours due to contrast issues.
  • modify styles to add focus when you use the tab key.
  • replace default alt attribute with the alt loaded from WordPress multimedia section.
  • add text inside detail links in our focus section.
  • add missing labels for inputs inside about us section.
@rodica-andronache

This comment has been minimized.

Show comment
Hide comment
@rodica-andronache

rodica-andronache Sep 15, 2016

Contributor

Hi @felixzapata ,

Thank you for your contribution. In order to test this, we would need the pull request to be created from the development branch. We work on development, and if everything is ok, we move it on production.

Regards,
Rodica

Contributor

rodica-andronache commented Sep 15, 2016

Hi @felixzapata ,

Thank you for your contribution. In order to test this, we would need the pull request to be created from the development branch. We work on development, and if everything is ok, we move it on production.

Regards,
Rodica

@felixzapata felixzapata changed the base branch from production to development Sep 15, 2016

@felixzapata

This comment has been minimized.

Show comment
Hide comment
@felixzapata

felixzapata Sep 15, 2016

Contributor

@rodica-andronache done. I´ve created a new branch based on development and change the base branch in the pull request.

Contributor

felixzapata commented Sep 15, 2016

@rodica-andronache done. I´ve created a new branch based on development and change the base branch in the pull request.

@rodica-andronache rodica-andronache merged commit 031bed9 into Codeinwp:development Oct 1, 2016

@rodica-andronache

This comment has been minimized.

Show comment
Hide comment
@rodica-andronache

rodica-andronache Oct 1, 2016

Contributor

Hi @felixzapata ,

Thank you so much for the contribution. It will be available in the next update.

Regards,
Rodica

Contributor

rodica-andronache commented Oct 1, 2016

Hi @felixzapata ,

Thank you so much for the contribution. It will be available in the next update.

Regards,
Rodica

@felixzapata

This comment has been minimized.

Show comment
Hide comment
@felixzapata

felixzapata Oct 2, 2016

Contributor

@rodica-andronache you´re welcome. Maybe we will send another pull request with more changes related with the accessibility. Some of them about the menu in small screens.

Contributor

felixzapata commented Oct 2, 2016

@rodica-andronache you´re welcome. Maybe we will send another pull request with more changes related with the accessibility. Some of them about the menu in small screens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment