From 791536ccda7306831498b20c853a52e2b0cebbcb Mon Sep 17 00:00:00 2001 From: Simon Puente Date: Fri, 3 Jul 2020 19:36:48 -0700 Subject: [PATCH 1/2] Tell make to use bash as its shell Exacuting make with ZSH shows `make: command: Command not found `, if BASH is a dependency then it could be a good idea to explicitly tell that to make. for more info: https://stackoverflow.com/questions/62721593/what-that-this-line-means-in-a-make-file-docker-shell-command-v-docker/62723364#62723364 --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index b490c5b..1133418 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,6 @@ .PHONY = default deps build test start clean start-database +SHELL := /bin/bash IMAGE_NAME := codelytv/typescript-ddd-skeleton SERVICE_NAME := app From 61b0c54d68559c557636ac2a3b066c787c10db90 Mon Sep 17 00:00:00 2001 From: Simon Puente Date: Fri, 10 Jul 2020 13:33:02 -0700 Subject: [PATCH 2/2] Update Makefile Co-authored-by: Francisco Ortiz --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 1133418..4d81a56 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,7 @@ .PHONY = default deps build test start clean start-database -SHELL := /bin/bash +# Shell to use for running scripts +SHELL := $(shell which bash) IMAGE_NAME := codelytv/typescript-ddd-skeleton SERVICE_NAME := app