fix windows UnicodeEncodeError after render completes#189
Merged
Conversation
Contributor
Author
|
Ahh... this doesn't fix the issue. Changing to draft. |
Contributor
Author
|
The new change is much simpler. Using I tested this branch on my AWS Workspaces Windows machine. |
Contributor
|
This doesn't feel like te real fix. The problem with encoding will still exists and can wait for us on the next corner. Have you tried this? |
Contributor
Author
|
@pedjaradenkovic I tried it out but it doesn't fix the issue. I'll dig into this and find a better solution. |
Contributor
Author
|
This works now and I think it's a better solution. I kept the |
75a01f6 to
573f8e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "✓ rendering completed" console output throws an error on Windows because of different encoding.
The error:
UnicodeEncodeError: 'charmap' codec can't encode character '\u2713' in position 42: character maps to <undefined>