Skip to content

Change misleading variable name #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NejcS merged 1 commit into from
Jun 5, 2026
Merged

Change misleading variable name #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions render_machine/actions/run_conformance_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def execute(self, render_context: RenderContext, _previous_action_payload: Any |
+ f"in module {render_context.conformance_tests_running_context.current_testing_module_name}"
+ ")."
)
exit_code, conformance_tests_issue, conformance_tests_temp_file_path = render_utils.execute_script(
exit_code, conformance_tests_issue, conformance_tests_temp_log_file_path = render_utils.execute_script(
conformance_tests_script,
[render_context.build_folder, conformance_tests_folder_name],
"Conformance Tests",
Expand All @@ -49,7 +49,9 @@ def execute(self, render_context: RenderContext, _previous_action_payload: Any |
timeout=render_context.test_script_timeout,
stop_event=render_context.stop_event,
)
render_context.script_execution_history.latest_conformance_test_output_path = conformance_tests_temp_file_path
render_context.script_execution_history.latest_conformance_test_output_path = (
conformance_tests_temp_log_file_path
)
render_context.script_execution_history.should_update_script_outputs = True

render_context.memory_manager.create_conformance_tests_memory(
Expand Down
4 changes: 2 additions & 2 deletions render_machine/actions/run_unit_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ def execute(self, render_context: RenderContext, _previous_action_payload: Any |
console.info(
f"Running unit tests script {unittests_script}. (attempt: {render_context.unit_tests_running_context.fix_attempts + 1})"
)
exit_code, unittests_issue, unittests_temp_file_path = render_utils.execute_script(
exit_code, unittests_issue, unittests_temp_log_file_path = render_utils.execute_script(
unittests_script,
[render_context.build_folder],
"Unit Tests",
timeout=render_context.test_script_timeout,
stop_event=render_context.stop_event,
)

render_context.script_execution_history.latest_unit_test_output_path = unittests_temp_file_path
render_context.script_execution_history.latest_unit_test_output_path = unittests_temp_log_file_path
render_context.script_execution_history.should_update_script_outputs = True
if exit_code == 0:
return self.SUCCESSFUL_OUTCOME, None
Expand Down
Loading