Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/ui registration #938

Merged
merged 2 commits into from Aug 11, 2016

Conversation

Projects
None yet
3 participants
@butlerx
Copy link
Member

commented Aug 9, 2016

change styling on login, reset and reset_password
add /reset link
add stepper to registration process and ask for profile information to complete profile on registration

scope: false,
templateUrl: '/directives/tpl/user/cd-register-user',
controller: [ '$scope', 'utilsService', '$translate', function($scope, utilsService, $translate) {
$scope.validatePassword = function (password, email) {

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 9, 2016

Contributor

utilsService or this?

return {
restrict: 'E',
templateUrl: '/directives/tpl/user/cd-register',
link: function (scope, element, attrs) {

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 9, 2016

Contributor

unused link :)


#signup-form {
position: relative;
min-height: 300px;

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 9, 2016

Contributor

what is this for?

@butlerx butlerx force-pushed the butlerx:enhancement/ui-registration branch from f5bb961 to fc68a21 Aug 9, 2016

animation: slideOutLeft 0.5s both ease;
}

@keyframes slideOutLeft {

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 9, 2016

Contributor

animations could be exported to be reused

return {
restrict: 'E',
templateUrl: '/directives/tpl/user/cd-reset-password',
link: function (scope, element, attrs) {

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 9, 2016

Contributor

unused link :)

}

userUtils.doRegister = function (userFormData) {
console.log(userFormData);

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 9, 2016

Contributor

console

</wz-step>
</wizard>
</div>
<div class="cd-dashboard cd-color-5-underline">

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 9, 2016

Contributor

don't we get rid off underlined titles?

@butlerx butlerx force-pushed the butlerx:enhancement/ui-registration branch 3 times, most recently from 0540b5a to dbe227d Aug 10, 2016

.btn {
-webkit-border-radius: 4px !important;
-moz-border-radius: 4px !important;
border-radius: 4px !important;

This comment has been minimized.

Copy link
@DanielBrierton

DanielBrierton Aug 11, 2016

Member

You can get rid of these now, I got rid of the * { border-radius: 0 !important; } rule. Round corners on ALL THE THINGS

@@ -0,0 +1,48 @@
.cd-login {
background: #fff;

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 11, 2016

Contributor

We probably should have a common class/element for this

This comment has been minimized.

Copy link
@DanielBrierton

DanielBrierton Aug 11, 2016

Member

I wonder if it's even needed anymore since we merged in the cd-menu changes

margin: 0;

span {
&.cd-msg-info {

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 11, 2016

Contributor

is cd-msg new ?

This comment has been minimized.

Copy link
@butlerx

butlerx Aug 11, 2016

Author Member

nope was always there

}

.input-group {
padding-right: 15px;

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 11, 2016

Contributor

how does this work on responsive?

return {
restrict: 'E',
templateUrl: '/directives/tpl/user/cd-register-profile',
link: function (scope, element, attrs) {

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 11, 2016

Contributor

unused link

@@ -0,0 +1,70 @@
.cd-register {
background-color: #fff;

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 11, 2016

Contributor

ref@before, reusing same comp

.cd-register {
background-color: #fff;

label.validationMessage {

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 11, 2016

Contributor

could/should be common

<div class="col-xs-12">
<div class="row">
<div class="input-group col-sm-6 col-sm-offset-3">
<span class="input-group-addon"><i class="fa fa-lock"></i></span>

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 11, 2016

Contributor

aria

<div class="col-xs-12">
<div class="row">
<div class="input-group col-sm-6 col-sm-offset-3">
<span class="input-group-addon"><i class="fa fa-lock"></i></span>

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 11, 2016

Contributor

aria

if(userFormData.referer){
$window.location.href = userFormData.referer;
} else {
$state.reload('register-account.user');

This comment has been minimized.

Copy link
@Wardormeur

Wardormeur Aug 11, 2016

Contributor

can we avoid reload? I mean, it's been a pain in the ass imho

@butlerx butlerx force-pushed the butlerx:enhancement/ui-registration branch from dbe227d to cbba69c Aug 11, 2016

@butlerx butlerx force-pushed the butlerx:enhancement/ui-registration branch from cbba69c to cdda38a Aug 11, 2016

@butlerx butlerx force-pushed the butlerx:enhancement/ui-registration branch from cdda38a to c1dc6a8 Aug 11, 2016

@Wardormeur Wardormeur merged commit a0a481f into CoderDojo:ui-refresh Aug 11, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@butlerx butlerx deleted the butlerx:enhancement/ui-registration branch Aug 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.