Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submissions for Assignment1 #2

Open
KenanBek opened this issue Mar 26, 2019 · 15 comments
Assignees
Labels

Comments

@KenanBek
Copy link
Contributor

@KenanBek KenanBek commented Mar 26, 2019

No description provided.

@KenanBek KenanBek added the assignment label Mar 26, 2019
@KenanBek KenanBek self-assigned this Mar 26, 2019
@KenanBek KenanBek changed the title Assignment 1 submissions Submissions for Assignment #1 Mar 26, 2019
@mirpulatov

This comment has been minimized.

@Jlopezjlx

This comment has been minimized.

@Prrrince

This comment has been minimized.

Copy link

@Prrrince Prrrince commented Mar 26, 2019

@HelSirius

This comment has been minimized.

@KenanBek

This comment has been minimized.

Copy link
Contributor Author

@KenanBek KenanBek commented Apr 4, 2019

@HelSirius that's great! We all probably need to move to PR instead of separate repositories. For this, I need to prepare a proper repo structure. Will to it today and publish tomorrow.

@mirpulatov @Jlopezjlx @Prrrince @HelSirius today will do all code reviews and merge your code into the main repository.

@HelSirius

This comment has been minimized.

Copy link
Contributor

@HelSirius HelSirius commented Apr 4, 2019

NIce! Thank you

@Jlopezjlx

This comment has been minimized.

Copy link

@Jlopezjlx Jlopezjlx commented Apr 4, 2019

Thank you!

@KenanBek

This comment has been minimized.

Copy link
Contributor Author

@KenanBek KenanBek commented Apr 5, 2019

To all members:

Comments for @HelSirius:

  • use naming conventions
  • use one variable for operations
  • add unit tests

Comments for @Prrrince:

  • I liked usage of Arrays, Try/Except
  • I would add one more Except for generic exception
  • add unit tests

Comments for @Jlopezjlx:

  • use endless loop (while)
  • use Try/Except
  • add unit tests

Comments for @mirpulatov:

  • use Try/Except
  • add unit tests
  • for class implementation add init.py to the folder
@KenanBek

This comment has been minimized.

Copy link
Contributor Author

@KenanBek KenanBek commented Apr 5, 2019

Video with the detailed comments will be published today (5 April, Friday)

@HelSirius

This comment has been minimized.

Copy link
Contributor

@HelSirius HelSirius commented Apr 5, 2019

Thank you for the comments .... I will fix it

@KenanBek

This comment has been minimized.

Copy link
Contributor Author

@KenanBek KenanBek commented Apr 5, 2019

Thank you for the comments .... I will fix it

@HelSirius please, fix it based on the latest version of the repository because it is updated and now contains your code. Before sending new PR I recommend you to wait for the Video with my comments. It will be published within a few hours.

@HelSirius

This comment has been minimized.

Copy link
Contributor

@HelSirius HelSirius commented Apr 5, 2019

@KenanBek sure! will wait for the video

@Jlopezjlx

This comment has been minimized.

Copy link

@Jlopezjlx Jlopezjlx commented Apr 6, 2019

HI, this is my PR request: #4

@mirpulatov

This comment has been minimized.

Copy link

@mirpulatov mirpulatov commented Apr 8, 2019

Hi. I did the fixes #5

@KenanBek

This comment has been minimized.

Copy link
Contributor Author

@KenanBek KenanBek commented Apr 8, 2019

@mirpulatov your PR is merged. @Jlopezjlx added 2 comments for your PR, please check them.

KenanBek added a commit that referenced this issue Apr 9, 2019
Endless loop and refactoring for the Assignment #2's solution by @Jlopezjlx
@KenanBek KenanBek changed the title Submissions for Assignment #1 Submissions for Assignment1 Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.