Skip to content

Fix - added preview for post editioning and when none answers yet #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

Fix - added preview for post editioning and when none answers yet #29

wants to merge 14 commits into from

Conversation

@ScriptyChris
Copy link
Member

@ScriptyChris ScriptyChris commented Jul 15, 2016

Fix to #24

Post preview is now also available when:

  • user edits his question, answer or comment
  • topic has zero answers

@ScriptyChris ScriptyChris self-assigned this Jul 15, 2016
@ScriptyChris ScriptyChris changed the title Fix - post preview for it's editing and when any answers yet Fix - added preview for post editioning and when none answers yet Jul 15, 2016
@efiku efiku added the Assigned label Jul 19, 2016
@efiku
Copy link
Member

efiku commented Jul 19, 2016 •
edited
Loading

Myślę, że może być okej.
Można merge + squash ( jeden commit z działającą zmianą )

efiku
efiku reviewed Jul 22, 2016
View reviewed changes
forum/qa-content/qa-page.js Outdated
document.body.appendChild(textArea);
////console.log('textArea: ', textArea.value);

// if anything on the page is selected (a.k.a highlighted) - clear the selection
Copy link
Member

@efiku efiku Jul 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary comment

efiku
efiku reviewed Jul 22, 2016
View reviewed changes
forum/qa-content/qa-page.js Outdated
function copyToClipboard(ev)
{
// check whether browser support 'copy' command
////if (document.queryCommandSupported('copy'))
Copy link
Member

@efiku efiku Jul 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary comment

@efiku
Copy link
Member

efiku commented Jul 22, 2016 •
edited
Loading

I can't merge this right now .
It contains unnecessary comments in code and unused code.
Seriously, try to learn how to use a debugger and your code will be better.
When you fix this, please squash your commits and remove label Work in progress

@ScriptyChris
Copy link
Member Author

ScriptyChris commented Jul 23, 2016 •
edited
Loading

@efiku
I know there are unnecessary comments in code. However i still improve code and what's more, i am adding few new features. So i think, i will do new PR with all clean and working, because comparing to this PR, there are going to be fixes and new features.

Sorry for messing with that current PR. I just have been pushing new changes to send links for users on IRC, who maybe wanted to test how it's working in reality and propose some changes (not for code review indeed).

[edit]
Anyway, thank You for comments about code.

@ScriptyChris ScriptyChris mentioned this pull request Jul 24, 2016
Merged
@ScriptyChris
Copy link
Member Author

ScriptyChris commented Jul 24, 2016

Fixes and improvements are placed here: #34

@awaluk awaluk deleted the hotfix/collapsing-blocks-of-code-and-post-preview branch November 17, 2016 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ScriptyChris ScriptyChris

Labels

Assigned Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ScriptyChris @efiku @event15