Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only confirm quitting if connections are active #526

Merged
merged 3 commits into from Mar 3, 2019

Conversation

Projects
None yet
3 participants
@williamleuschner
Copy link
Contributor

williamleuschner commented Jan 25, 2019

Hello!

This patch fixes a tiny thing that's been bugging me for a while now: Textual always asks for confirmation when quitting, even when there are no connections open and quitting isn't a destructive action. I've never written Objective-C before, so I don't know if this patch is the "most correct" way of solving the problem. I did test it though, and it builds and runs without errors or unexpected behavior.

Is this a change you'd be willing to accept?

(P.S. Thanks for developing Textual! It's my favorite IRC client.)

@emsquared

This comment has been minimized.

Copy link
Contributor

emsquared commented Mar 3, 2019

Could you possibly resubmit this without the changes to the .xib file as I am a complete retard with git and don't want to merge that.

@dgw

This comment has been minimized.

Copy link
Contributor

dgw commented Mar 3, 2019

@williamleuschner You can rebase and force-push to undo the .xib changes, without opening a new PR.

I'd write instructions, but am very short on time. So, this will give you a chance to figure it out yourself I guess. If you get stuck I can take time to help you for real later.

@emsquared Happy to teach you at the same time, too, if you're interested. Rebasing is a useful skill. :)

@williamleuschner williamleuschner force-pushed the williamleuschner:FEATURE/conditional-confirm-quit branch from 5e72420 to 3a71c9d Mar 3, 2019

@williamleuschner

This comment has been minimized.

Copy link
Contributor Author

williamleuschner commented Mar 3, 2019

@emsquared Sure! Just did.

@dgw I typically work in a merge-heavy Git workflow, so I avoid rebases and force-pushes because they make the Git history less clear. I partially reverted the commit instead (and also messed up and needed to force-push to fix it anyway).

@emsquared emsquared merged commit 3a71c9d into Codeux-Software:dev Mar 3, 2019

@emsquared

This comment has been minimized.

Copy link
Contributor

emsquared commented Mar 3, 2019

Well I think I managed to merge it. :)

@dgw

This comment has been minimized.

Copy link
Contributor

dgw commented Mar 3, 2019

@williamleuschner That works too, if the maintainer doesn't mind revert commits! I'm used to projects preferring squashed/rebased PRs when possible.

@williamleuschner

This comment has been minimized.

Copy link
Contributor Author

williamleuschner commented Mar 3, 2019

Ah, okay. Good to know, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.