Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Only confirm quitting if connections are active #526
This patch fixes a tiny thing that's been bugging me for a while now: Textual always asks for confirmation when quitting, even when there are no connections open and quitting isn't a destructive action. I've never written Objective-C before, so I don't know if this patch is the "most correct" way of solving the problem. I did test it though, and it builds and runs without errors or unexpected behavior.
Is this a change you'd be willing to accept?
(P.S. Thanks for developing Textual! It's my favorite IRC client.)
@williamleuschner You can rebase and force-push to undo the .xib changes, without opening a new PR.
I'd write instructions, but am very short on time. So, this will give you a chance to figure it out yourself I guess. If you get stuck I can take time to help you for real later.
@emsquared Happy to teach you at the same time, too, if you're interested. Rebasing is a useful skill. :)