New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed vulnerability. #974
Fixed vulnerability. #974
Conversation
view-source: codiad/data/users.php nginx with fast cgi will disclose the commented out json unless you add a new line before hand. Fixes username, password "sha1(md5(password))", and last project from being disclosed to public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about all other php files in the data directory?
|
@daeks this also addresses those since they all use the same function. If this is pushed to main branch, upon installation everything will work properly for all files. Also, if you update your current version with this code it will fix your files upon save. |
|
At least project.php has the "old" syntax
|
|
Then what ever writes to that isn't using the same function that was updated. |
|
I have checked the code and the function which is missing is used in /components/install/process.php. This function should be updated as well to reflect your changes. |
added \r\n to saveJSON function to prevent sensitive information disclosure
|
added new line to process.php saveJSON function, should do the trick. |
view-source: codiad/data/users.php
nginx with fast cgi will disclose the commented out json unless you add a new line before hand.
Fixes username, password "sha1(md5(password))", and last project from being disclosed to public.
Server setup:
ubuntu yakkety
php7.0-fpm
nginx-full
default php7.0-fpm php.ini