-
-
Notifications
You must be signed in to change notification settings - Fork 74
feat: use qs_dart in buildUrlString for enhanced query string encoding
#158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@CodingAleCR I have added URL validation to the |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
# Conflicts: # lib/utils/query_parameters.dart # test/utils/utils_test.dart
buildUrlStringbuildUrlString for enhanced query string encoding
|
@all-contributors add @techouse for code and docs |
|
I've put up a pull request to add @techouse! 🎉 |
Thank you for contributing to the library, I'm sorry it took so long 🙏🏻 |
|
@CodingAleCR no worries 😊 |
👋 Hi there! I’m the author of qs_dart, a Dart port of qs for JavaScript.
I’ve given the
buildUrlStringutility method a thorough overhaul to boost its reliability and maintainability. Below is a summary of the key improvements:🚀 Core Enhancements
ArgumentErrorfor malformed or non-HTTP(S) URLsUri.parseand basic checks - no more ad-hoc string assumptions🛠️ New Dependencies
✅ Expanded Test Coverage
Added new cases in test/utils/utils_test.dart to validate:
null/ empty maps, empty‐string values, overriding existing keys@,/), spaces vs. plus signsThese tests ensure that
buildUrlStringbehaves correctly across all common and edge scenarios.