Skip to content

Conversation

@jonnytest1
Copy link

@jonnytest1 jonnytest1 commented Jul 15, 2022

made a small helper class for general grid layouts (partially copied from things i did previously)

its currently still not integrated perfectly so its just here as an idea

im thinking it might be unifiable if
Cell.down etc was expressed as Cell[createVector(0,-1)]

because then it possible to just invert the directional offset vector to reference the validOptions of a connection

(since this would be a slightly bigger change i stopped halfway through because i thought i'd get some feedback before rewriting it all ^^)

some more ideas can be gleaned off this class structure i made a while ago
https://github.com/jonnytest1/workadventure-mapserver/blob/master/resources/mapserver/service/generic-map-factory/game-map-map-factory.ts
for a minesweeper game

@shiffman
Copy link
Member

shiffman commented Jan 26, 2025

Many apologies!!! I know it's been almost 3 years since these PRs! I am releasing a new video next week on the overlapping model and did some work to refactor this repository. Would you like to revisit this? Because it introduces typescript and additional complexity it likely makes more sense for me to link out to this from the repo's README. Let me know what you think!

@jonnytest1
Copy link
Author

phew ^^ i have no clue what that was anymore

you can definitely link to it if you want

(as for the typescript , i dont think its a big problem since this is jsdoc , it runs just fine in any javascript environment 🤔)

shiffman added a commit that referenced this pull request Jan 26, 2025
@shiffman
Copy link
Member

Ah, I see what you mean re: typescript. It's more that I am trying to keep this repo simple for p5.js coders who are often beginners and not familar with the broader JS ecosystem. Closing this and we can discusss in #46 Thank you!

@shiffman shiffman closed this Jan 26, 2025
shiffman added a commit that referenced this pull request Jan 26, 2025
* Adding community contribution

Re: #39

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants