Skip to content
This repository has been archived by the owner on Jul 5, 2022. It is now read-only.

Hacktoberfest - Make Something 💖 and Share A Link on The Coding Train Website #2615

Closed
duskvirkus opened this issue Oct 2, 2020 · 21 comments

Comments

@duskvirkus
Copy link
Member

duskvirkus commented Oct 2, 2020

Hello hackers!

All aboard The Coding Train 🚂🌈💖! The Coding Train is an educational YouTube channel where Dan Shiffman teaches JavaScript and Java with p5.js and Processing.

A great way to contribute is by sharing a project you make based on one of the coding challenge videos on the Coding Train YouTube channel. Here's a couple simple steps to tell you how:

  1. Choose and watch a Coding Challenge. You can see all the coding challenges on our website: https://thecodingtrain.com/CodingChallenges/. Below are a couple of favorites that people enjoy remixing.
  1. Make something!! Make something cool based on the coding challenge. An in browser code editor is the p5.js web editor (no install required). Just hit View Code or Web Editor on the coding challenge webpage to see the code from the video if you don't want to start from scratch.

  2. Add a link to your creation to the site with a pull request. We have a whole guide on doing this which can be found here: https://thecodingtrain.com/Guides/community-contribution-guide. There's also a video of Dan showing how it's done: https://youtu.be/fkIr0inoQ7Y.

Thanks for checking out The Coding Train. We hope you stay awhile and enjoy making fun projects!

If you've got any questions about the process feel free to ask them below. And if you want help coding or debugging check out our discord server: https://discord.gg/hPuGy2g.

Side note, please do not say that your pull request closes this issue. It will be closed at the end of the month.

Please follow our code of conduct: https://github.com/CodingTrain/Code-of-Conduct

@duskvirkus duskvirkus changed the title Hacktober - Make Something Great and Share A Link on The Coding Train Website Hacktoberfest - Make Something Great and Share A Link on The Coding Train Website Oct 2, 2020
@gruselhaus gruselhaus pinned this issue Oct 2, 2020
@shiffman shiffman changed the title Hacktoberfest - Make Something Great and Share A Link on The Coding Train Website Hacktoberfest - Make Something 💖 and Share A Link on The Coding Train Website Oct 2, 2020
phg98 added a commit to phg98/website that referenced this issue Oct 4, 2020
Add Beginners Introdunction contribution CodingTrain#2615
phg98 added a commit to phg98/website that referenced this issue Oct 4, 2020
@thinkswell
Copy link
Contributor

@violetcraze, Hello, I have made an amazing version of flappy bird it's my first contribution to coding train, can you please review it, PR #2654
Thank You.

duskvirkus added a commit that referenced this issue Oct 6, 2020
Random circles generating pattern

Link to demo : https://phg98.github.io/phg98p5sample/

Co-authored-by: Violet <43045568+violetcraze@users.noreply.github.com>
@galElmalah
Copy link
Contributor

Hey, do we need to mention the PR here or just opening one is enough?
just in case 😄
#2701

This was referenced Oct 11, 2020
duskvirkus added a commit that referenced this issue Oct 11, 2020
* Update 114-bubble-sort.md

* ci fix

Co-authored-by: Violet <43045568+violetcraze@users.noreply.github.com>
duskvirkus added a commit that referenced this issue Oct 12, 2020
* Update 085-the-game-of-life.md

Added my photo to cellular automata exemple to the contributions

* Update 085-the-game-of-life.md

Better description of my contribution

#2615

* Update 085-the-game-of-life.md

Fixed missing character at the end of the line

#2615

* Update 085-the-game-of-life.md

Co-authored-by: Violet <43045568+violetcraze@users.noreply.github.com>
duskvirkus added a commit that referenced this issue Oct 15, 2020
Link to Demo here : https://amnindersingh12.github.io/two-pie/
Regarding #2615

Co-authored-by: Violet <43045568+violetcraze@users.noreply.github.com>
This was referenced Oct 15, 2020
JacobGeoGeek added a commit to JacobGeoGeek/website that referenced this issue Oct 27, 2020
duskvirkus added a commit that referenced this issue Oct 27, 2020
* Visualizing map for displaying Covid-19 # of cases

this PR was made for the hacktoberfest 2020 #2615 
here's link for the demo: https://editor.p5js.org/JacobGeoGeek/full/AZaXEefqr

* format the yml

Co-authored-by: Violet <43045568+violetcraze@users.noreply.github.com>
@duskvirkus duskvirkus mentioned this issue Oct 27, 2020
1 task
JacobGeoGeek added a commit to JacobGeoGeek/website that referenced this issue Oct 28, 2020
this PR is related to CodingTrain#2615 in which I have displayed number of cases on a 3D map by using the `height` property of the boxes 

Happy Hacktoberfest 2020
duskvirkus added a commit that referenced this issue Oct 29, 2020
* display the # of COVID cases on a 3D map

this PR is related to #2615 in which I have displayed number of cases on a 3D map by using the `height` property of the boxes 

Happy Hacktoberfest 2020

* remove the extra space

* remove the space

Co-authored-by: Violet <43045568+violetcraze@users.noreply.github.com>
@duskvirkus
Copy link
Member Author

Thanks to everyone who participated in Hacktoberfest!

@duskvirkus duskvirkus unpinned this issue Nov 2, 2020
@b-yogesh
Copy link
Contributor

b-yogesh commented Nov 3, 2020

Hello @violetcraze , I had participated in Hacktoberfest 2020, and my 2 PRs were supposed to mature today and 1 PR tomorrow, but since you closed this issue, now it shows that this is Ineligible repository. Can this be fixed somehow? Thank you.

@JacobGeoGeek
Copy link
Contributor

I also have the same problem

@duskvirkus
Copy link
Member Author

@b-yogesh @JacobGeoGeek So sorry about that. I was cleaning up and removed the label from the repository. Just added it again. Please let me know if that fixed it. If not, I was told over on #2762 that I can label specific pull request to be accepted and I'll go back and add that label.

@JacobGeoGeek
Copy link
Contributor

JacobGeoGeek commented Nov 3, 2020

Hello @violetcraze,

what do you mean by "Just added it again".
not sure if that Can help you, but here's my two PRs: #2821 and #2815

Cheers

@decrecementofeliz
Copy link
Contributor

Hi @violetcraze I had the same problem, my PR is shown as Ineligible
#2839
Can you have a look? thanks

@b-yogesh
Copy link
Contributor

b-yogesh commented Nov 3, 2020

Hi @violetcraze, thanks for replying. No, it has not fixed my problem yet. :( #2758, #2759 and #2772 are all ineligible now. Can you try adding that opening this issue again? or is there any other way to get our PRs accepted?

@duskvirkus
Copy link
Member Author

@JacobGeoGeek @decrecementofeliz @b-yogesh
I'm going back and adding hacktoberfest-accepted labels to all the pull request that might have been effected in the hope fixes things, but I think even if that's working it won't fix pull requests that matured in the last 24 hours or so. I'm also waiting to hear back from hacktoberfest support to make sure all the pull requests are counted. If this all plays out and you end up not meeting the requirements because of hacktoberfest label being removed from the repository I'll send you some Coding Train merch or donate to have a tree planted.

@JacobGeoGeek
Copy link
Contributor

@violetcraze thanks for the support

@b-yogesh
Copy link
Contributor

b-yogesh commented Nov 3, 2020

@violetcraze thank you. :)

@duskvirkus
Copy link
Member Author

Update:
I got a message back from hacktoberfest support here's what it said.

Our team are aware of this issue and are looking into a possible solution for it.

However, at present, this is the intended behaviour of Hacktoberfest. If a maintainer removes the topic or un-accepts a PR during the review period, that PR will become invalid. As Hacktoberfest has now ended, even if the maintainer re-accepts the PR or adds the topic back, the PR can no longer start the review period again, so will be stuck as invalid.

Sounds like they're working on a solution and I'll follow up in 3 days to see where things are at if I don't hear back by then.

@decrecementofeliz
Copy link
Contributor

thank you @violetcraze

@DenisovichDev
Copy link
Member

@violetcraze You are very kind. I've had the same problem too, although I didn't mention this issue in any of my pull requests, so basically it's my fault. But if you get any news let us know. Thanks for being so kind to care! Cheers!

@duskvirkus
Copy link
Member Author

Update:
Haven't heard back from the Hacktoberfest team yet so I send a follow up email asking for more details and if they intend on releasing a solution and if so when. I'll follow up one more time if I don't hear back by Tuesday next week.

@JacobGeoGeek
Copy link
Contributor

thanks for the update

@duskvirkus
Copy link
Member Author

Update:
Got this message back from Hacktoberfest.

Our team are aware of this issue and are looking into a possible solution for it, however, at present, we cannot provide any updates.

I'll follow up next Monday if I don't hear anything by then.

@duskvirkus
Copy link
Member Author

Sorry for the delayed update. Have emailed Hacktoberfest again asking for more definite time frame for a solution or if they intend on fixing this issue at all. I apologies that this process is taking so long. I'll post an update when I get a response it normally takes a day or two.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants