Skip to content
Permalink
Browse files

[Admin] Code prettification and bugfixing (#3250)

* Facelift for Admin

* Remove unnecessary converter, reorder existing steps

* Delete admin.py

* Delete __init__.py

* Delete test_admin.py

* Remove one extra unneeded check

* Create 3250.bugfix.1.rst

* Create 3250.bugfix.2.rst

* Create 3250.bugfix.3.rst

* Create 3250.bugfix.4.rst

* Create 3250.misc.1.rst

* Create 3250.misc.2.rst

* Create 3250.misc.3.rst

* Create 3250.breaking.1.rst

* Create 3250.breaking.2.rst

* ...

* I hate black...
  • Loading branch information
Flame442 authored and mikeshardmind committed Jan 2, 2020
1 parent 36e2cde commit e776b5ca1a3ac14ac2573826510cdfe4dbde382e
@@ -0,0 +1 @@
Changed ``[p]announce ignore`` and ``[p]announce channel`` to ``[p]announceset ignore`` and ``[p]announceset channel``.
@@ -0,0 +1 @@
Changed ``[p]selfrole <role>`` to ``[p]selfrole add <role>``, changed ``[p]selfrole add`` to ``[p]selfroleset add`` , and changed ``[p]selfrole delete`` to ``[p]selfroleset remove``.
@@ -0,0 +1,2 @@
Improved the clairty of user facing messages in the admin cog when the user is not allowed
to do something due to Discord hierarchy rules.
@@ -0,0 +1 @@
Fixed some role managing commands not properly checking if the bot had manage_roles perms before attempting to manage roles.
@@ -0,0 +1 @@
Fixed ``[p]editrole`` commands not checking if roles to be edited are higher than the bot's highest role before trying to edit them.
@@ -0,0 +1 @@
Fixed ``[p]announce ignore`` and ``[p]announce channel`` not being able to be used by guild owners and administrators.
@@ -0,0 +1 @@
Removed Admin tests.
@@ -0,0 +1 @@
Removed the ``MemberDefaultAuthor`` converter because its only purpose seemed to be catching ``""`` "members".
@@ -0,0 +1 @@
The ``SelfRole`` converter now only makes a config get call when the role actually exists.

0 comments on commit e776b5c

Please sign in to comment.
You can’t perform that action at this time.