[RPC] Set custom port with flags #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobotimus
added
the
Type: Enhancement
Tobotimus
requested review from
Tobotimus
and removed request for
tekulvw and
Twentysix26
mikeshardmind
previously requested changes
Oct 2, 2019
mikeshardmind
added
the
Changelog Entry: Pending
Kowlin
removed
the
Changelog Entry: Pending
mikeshardmind
dismissed
their stale review
Only the changelog part was meant as blocking, which is handled
mikeshardmind
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
As mentioned in #2423, having multiple instances with an RPC server will cause issues, due to multiple programs using the same port. This is a small addition that prevents the issue by adding a
--rpc-portflag toredbot, allowing to set his own port. If not specified, it is still default to 6133.The best fix to the RPC issue would be to have only one running server for all instances, but that would require a lot of changes to make the instances communicate between them and I don't feel like I can do such changes.