Spelling correction of method name in Tunnel

[Jackenmen]

Type

• Bugfix
• Enhancement
• New feature

Description of the changes

Fix for wrong spelling in method name files_from_attatch, I changed it to files_from_attach in all its appearances.

This is actually breaking change, because of change of method's name, lol.

[mikeshardmind]

I'd prefer if this was done in a non-breaking fashion for now given how much QA has recommended people use this method when they need files in a quick and easy way.

    @property
    def files_from_attatch(self):
        return self.files_from_attach

Adding this to the Tunnel class with your changes would be sufficient for that, the property could then be removed later on.

[Jackenmen]

Because it is static method this would still be breaking change, because now you would have to create instance before using the method. I think it should be enough to just do a simple assignment to old name after defining the method.

files_from_attatch = files_from_attach

[mikeshardmind]

Right, forgot that was made a static method for a moment.

[Jackenmen]

I added it then.

[Jackenmen]

Red-DiscordBot/redbot/core/utils/tunnel.py

Lines 73 to 76 in e3cb29f

	async def react_close(self, *, uid: int, message: str = ""):
	send_to = self.origin if uid == self.sender.id else self.sender
	closer = next(filter(lambda x: x.id == uid, (self.sender, self.recipient)), None)
	await send_to.send(filter_mass_mentions(message.format(closer=closer)))

also, I wanted to add PR for this, because it looks like bad logic to me, this will always send the message to the side that started the tunnel, either original channel, or the sender that the bot reacts to on this channel - I think it should be:

send_to = self.recipient if uid == self.sender.id else self.origin

I just thought that maybe I could do it in this PR (assuming this isn't some strange logic that I just don't understand)

[mikeshardmind]

your logic is solid there and properly fixes the intent (of sending a message of the tunnel being closed to the other end)

[Jackenmen]

Can I do it here or should I just do another PR?

[Tobotimus]

@jack1142 Another PR would be great for that change.

As for this PR, could you just add this comment above line 161?

# Backwards-compatible typo fix (GH-2496)

[Jackenmen]

Ayy, I wanted to do that from the beginning (I wouldn't have thought of adding PR number though), I'll commit it in a second

[Jackenmen]

@Tobotimus updated, I'll add the other PR later today.

[Tobotimus]

Thanks @jack1142!