Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Downloader] [p]repo add command doesn't disallow what's said in help. #2827

Closed
jack1142 opened this issue Jul 1, 2019 · 0 comments · Fixed by #3029
Closed

[Downloader] [p]repo add command doesn't disallow what's said in help. #2827

jack1142 opened this issue Jul 1, 2019 · 0 comments · Fixed by #3029
Labels
Good First Issue Type: Bug

Comments

@jack1142
Copy link
Member

@jack1142 jack1142 commented Jul 1, 2019

Command bugs

Command name

[p]repo add

What cog is this command from?

Downloader

What were you expecting to happen and what in fact happen?

According to help, name of the repo should "only contain characters A-z, numbers and underscores", so when I used names with characters that aren't one of those to fail, but instead it turned out that I can freely use space, hyphen, dollar sign, etc.

How can we reproduce this issue?

Just try adding repo with name that contains some other characters, for example test$2

@Tobotimus Tobotimus added the Type: Bug label Jul 3, 2019
@mikeshardmind mikeshardmind added the Good First Issue label Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants