Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tunnel] Allow to use proxy_url for attachments in files_from_attach #2885

Closed
1 of 3 tasks
jack1142 opened this issue Jul 17, 2019 · 2 comments
Closed
1 of 3 tasks

[Tunnel] Allow to use proxy_url for attachments in files_from_attach #2885

jack1142 opened this issue Jul 17, 2019 · 2 comments
Labels
Status: In Progress Type: Enhancement

Comments

@jack1142
Copy link
Member

@jack1142 jack1142 commented Jul 17, 2019

Feature request

Select the type of feature you are requesting:

  • Cog
  • Command
  • API functionality

Describe your requested feature

Tunnel.files_from_attach function could be extended to allow the use of cached attachments, which would make it more useful when the message is deleted but the images are still available under proxy_url.

Would also be nice if it could skip files that aren't images and therefore aren't cached instead of throwing exception because of the single file when all the others were images.

@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Jul 17, 2019

While im not completely against supporting the proxy url, I'm not at all in favor of intentionally circumventing message deletion in core utils. The core bot should be generally safe.to use without major privacy law concerns.

@mikeshardmind mikeshardmind added the Status: Needs Discussion label Jul 17, 2019
jack1142 added a commit to jack1142/Red-DiscordBot that referenced this issue Jul 17, 2019
jack1142 added a commit to jack1142/Red-DiscordBot that referenced this issue Jul 17, 2019
@mikeshardmind mikeshardmind added Status: In Progress and removed Status: Needs Discussion labels Jul 17, 2019
@Tobotimus Tobotimus added the Type: Enhancement label Jul 19, 2019
mikeshardmind pushed a commit that referenced this issue Sep 28, 2019
…ach` (#2887)

* feat(tunnel): add `use_cached` kwarg

re #2885

* feat(tunnel): add `images_only` kwarg

re #2885

* chore(changelog): add towncrier entry
@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Sep 28, 2019

added in #2887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress Type: Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants