Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bank] Bank transfer logic at max balance #2923

Closed
aikaterna opened this issue Aug 8, 2019 · 1 comment
Closed

[Bank] Bank transfer logic at max balance #2923

aikaterna opened this issue Aug 8, 2019 · 1 comment
Labels
Type: Bug

Comments

@aikaterna
Copy link
Member

@aikaterna aikaterna commented Aug 8, 2019

Command bugs

Command name

bank transfer

What cog is this command from?

bank

What were you expecting to happen?

For a user to keep their credits after a failed transfer attempt.

What actually happened?

The transfer amount disappeared into the void.

How can we reproduce this issue?

Users A and B both have 60% of max balance amount in their bank. User A gives User B 50% of the max balance amount via the bank transfer command. User B would now at 110% of max balance and the bot replies "User B's balance cannot rise above 9,223,372,036,854,775,807 credits." However, User A will now be at 10% of max balance instead of the expected 60% of max. The transfer amount is being deducted from User A's balance when it shouldn't have been.

@Flame442 Flame442 added the Type: Bug label Aug 9, 2019
@Flame442
Copy link
Member

@Flame442 Flame442 commented Aug 27, 2019

Fixed by #2925

@Flame442 Flame442 closed this Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants