Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Setup] Deleting doesn't work. #2955

Closed
jack1142 opened this issue Aug 28, 2019 · 0 comments · Fixed by #2958
Closed

[Setup] Deleting doesn't work. #2955

jack1142 opened this issue Aug 28, 2019 · 0 comments · Fixed by #2958
Labels
Type: Bug

Comments

@jack1142
Copy link
Member

@jack1142 jack1142 commented Aug 28, 2019

Other bugs

What were you trying to do?

Delete instance with redbot-setup delete instancename

What were you expecting to happen?

Successfully delete the instance.

What actually happened?

I got traceback about unexpected keyword argument:

Traceback
Traceback (most recent call last):
  File "venv\Scripts\redbot-setup-script.py", line 11, in <module>
    load_entry_point('Red-DiscordBot', 'console_scripts', 'redbot-setup')()
  File "venv\lib\site-packages\click\core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "venv\lib\site-packages\click\core.py", line 717, in main
    rv = self.invoke(ctx)
  File "venv\lib\site-packages\click\core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "venv\lib\site-packages\click\core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "venv\lib\site-packages\click\core.py", line 555, in invoke
    return callback(*args, **kwargs)
TypeError: delete() got an unexpected keyword argument 'remove_datapath'

How can we reproduce this issue?

Try to delete instance.


I have PR almost ready, this is just informational.

jack1142 added a commit to jack1142/Red-DiscordBot that referenced this issue Aug 28, 2019
@Tobotimus Tobotimus added the Type: Bug label Aug 28, 2019
Tobotimus pushed a commit that referenced this issue Aug 29, 2019
- ``redbot-setup delete`` no longer errors about "unexpected keyword argument" (fix #2955)
- ``redbot-setup delete`` no longer prompts about backup when user passes ``--no-prompt`` option (fix #2956)
- ``--[no-]backup``, ``--[no-]drop-db`` and ``--[no-]remove-datapath`` in ``redbot-setup delete`` command are now on/off flags. ``--no-prompt`` was changed to flag too, but it doesn't have ``--prompt`` equivalent as there's no much point in having it
- ``redbot-setup`` now uses `click.confirm` for confirmation prompts and thy now also have default values for user convenience
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants