Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve [p]cancel #2973

Closed
1 of 3 tasks
zephyrkul opened this issue Sep 1, 2019 · 1 comment · Fixed by #2977
Closed
1 of 3 tasks

Reserve [p]cancel #2973

zephyrkul opened this issue Sep 1, 2019 · 1 comment · Fixed by #2977
Labels
Status: In Progress

Comments

@zephyrkul
Copy link
Contributor

@zephyrkul zephyrkul commented Sep 1, 2019

Feature request

Select the type of feature you are requesting:

  • Cog
  • Command
  • API functionality

Describe your requested feature

Reserve a no-op [p]cancel command, which is currently used by the built-in cancelled predicate, in the core cog, with a valid docstring, in order to prevent surprising behavior from other third-party cogs registering that command.

@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Sep 2, 2019

Rather than reserving a command here, it might be better to forbid the use of a list of strings as command names or alises and raise an error explaining this when someone attempts to create a command named as such.

This prevents us from dispatching on a no-op while still preventing the surprising behaviors.

@mikeshardmind mikeshardmind added the Status: In Progress label Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants