Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Bot's status isn't cleared on auto-disconnect #3050

Closed
jack1142 opened this issue Oct 11, 2019 · 2 comments · Fixed by #3119
Closed

[Audio] Bot's status isn't cleared on auto-disconnect #3050

jack1142 opened this issue Oct 11, 2019 · 2 comments · Fixed by #3119
Labels
Type: Bug

Comments

@jack1142
Copy link
Member

@jack1142 jack1142 commented Oct 11, 2019

Other bugs

Bot's status isn't cleared on auto-disconnect. It was already happening before Draper's PR came in.

How can we reproduce this issue?

  1. [p]audioset emptydisconnect 10
  2. [p]play audio url
  3. Leave channel and wait 10 seconds for the bot to leave it as well.
  4. Status still shows up.
@Flame442 Flame442 added the Type: Bug label Oct 12, 2019
@Drapersniper
Copy link
Contributor

@Drapersniper Drapersniper commented Nov 14, 2019

@jack1142 just to check, have you toggle [p]audioset status ? I assume so but just wanted to check.

Having a skim through the code and _status_check() is only called when status is set to True.

It then runs on LavalinkEvents.TRACK_START, LavalinkEvents.TRACK_END and LavalinkEvents.QUEUE_END

Auto disconnect should trigger a QUEUE_END so without doing any testing it seems that the only reason why this wouldn't reset the status is if the status was disabled after the track started playing.

@jack1142
Copy link
Member Author

@jack1142 jack1142 commented Nov 14, 2019

@Drapersniper yes I do have [p]audioset status set to true, I forgot to put it in reproduction steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants