Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit events when a shared API token is changed #3134

Closed
1 of 3 tasks
mikeshardmind opened this issue Nov 17, 2019 · 2 comments · Fixed by #3146
Closed
1 of 3 tasks

Emit events when a shared API token is changed #3134

mikeshardmind opened this issue Nov 17, 2019 · 2 comments · Fixed by #3146
Labels
Type: Feature
Milestone

Comments

@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Nov 17, 2019

Feature request

Select the type of feature you are requesting:

  • Cog
  • Command
  • API functionality

Describe your requested feature

Should emit the name of the service which was updated. This will allow cogs to cache the values and only update when if they change.

@zephyrkul
Copy link
Contributor

@zephyrkul zephyrkul commented Nov 23, 2019

Doesn't config already use a cache? Also, would it be worth expanding the event scope to consider config changes overall?

@mikeshardmind
Copy link
Contributor Author

@mikeshardmind mikeshardmind commented Nov 23, 2019

Config doesn't cache for DB backends. This is one of the only places 3rd party code might be caching a setting in nonobvious way (such as a single aiohttp client session) and should receive an indication to update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants