Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] [p]blacklist add fails when trying to add an uncached user #3220

Closed
jack1142 opened this issue Dec 25, 2019 · 0 comments · Fixed by #3472
Closed

[Core] [p]blacklist add fails when trying to add an uncached user #3220

jack1142 opened this issue Dec 25, 2019 · 0 comments · Fixed by #3472
Labels
Category: Bot Core Good First Issue Status: Accepted Status: PRs Welcome Type: Bug

Comments

@jack1142
Copy link
Member

@jack1142 jack1142 commented Dec 25, 2019

Command bugs

Command name

[p]blacklist add

What cog is this command from?

Core

What were you expecting to happen?

Command to run successfully.

What actually happened?

Got an error:

Exception in command 'blacklist add'
Traceback (most recent call last):
  File "/home/ubuntu/red-venv/lib/python3.7/site-packages/discord/ext/commands/core.py", line 79, in wrapped
    ret = await coro(*args, **kwargs)
  File "/home/ubuntu/red-venv/lib/python3.7/site-packages/redbot/core/core_commands.py", line 1753, in blacklist_add
    if await ctx.bot.is_owner(user):
  File "/home/ubuntu/red-venv/lib/python3.7/site-packages/redbot/core/bot.py", line 481, in is_owner
    if user.id in self._co_owners:
AttributeError: 'int' object has no attribute 'id'

How can we reproduce this issue?

Run [p]blacklist add 123

@jack1142 jack1142 added the Type: Bug label Dec 25, 2019
@mikeshardmind mikeshardmind added the Good First Issue label Jan 4, 2020
@Flame442 Flame442 added Status: Accepted Status: PRs Welcome labels Jan 8, 2020
TrustyJAID added a commit to TrustyJAID/Red-DiscordBot that referenced this issue Feb 13, 2020
Add caching for ignored guilds and channels
Add caching for whitelist and blacklist
Fix Cog-Creators#3220
Add consume-rest for whitelist and blacklist commands to add multiple users or roles in one command
mikeshardmind pushed a commit that referenced this issue Feb 15, 2020
* Move ignored guilds and channels to core
Add caching for ignored guilds and channels
Add caching for whitelist and blacklist
Fix #3220
Add consume-rest for whitelist and blacklist commands to add multiple users or roles in one command

* Add ability to ignore channel categories

* black

* moveignorechannels should be owner only and cleanup changes

* add changelog entries

* address Feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bot Core Good First Issue Status: Accepted Status: PRs Welcome Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants