Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Venv guide - using %userprofile% is unsafe when username has spaces #3411

Closed
jack1142 opened this issue Jan 19, 2020 · 5 comments
Closed
Labels
Category: Docs Status: Accepted

Comments

@jack1142
Copy link
Member

jack1142 commented Jan 19, 2020

Example issue:

C:\Users\Space Ranger>py -3.8 -m venv %userprofile%\redenv
Error: [Errno 13] Permission denied: 'C:\\Users\\Space\\pyvenv.cfg'
@jack1142 jack1142 added Category: Docs Status: Accepted labels Jan 19, 2020
@mikeshardmind
Copy link
Contributor

mikeshardmind commented Jan 19, 2020

Recommended route: Update venv guide to continue using PowerShell from the install guide, use $env:USERPROFILE

Other proper escaping or argument quoting of this is also acceptable

@palmtree5
Copy link
Member

palmtree5 commented Jan 19, 2020

quotes should do the trick but I'm inclined to agree with @mikeshardmind that we should probably update this to use powershell since that's our recommended install method on Windows

@Drapersniper
Copy link
Contributor

Drapersniper commented Jan 24, 2020

Hmm a lot of users will end up installing red as admin if this is the case though as when they open power shell they are told to open it as admin

@mikeshardmind
Copy link
Contributor

mikeshardmind commented Jan 24, 2020

They are also given a command which exits powershell. We shouldn't make our directions worse for people reading them, just because people not reading them could make a mistake.

@jack1142
Copy link
Member Author

jack1142 commented Feb 21, 2020

Fixed with #3495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Docs Status: Accepted
Projects
None yet
Development

No branches or pull requests

4 participants