Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Economy] Payday #3438

Closed
Stonedestroyer opened this issue Jan 24, 2020 · 0 comments · Fixed by #3496
Closed

[Economy] Payday #3438

Stonedestroyer opened this issue Jan 24, 2020 · 0 comments · Fixed by #3496
Labels
Status: In Progress Type: Bug

Comments

@Stonedestroyer
Copy link
Contributor

Stonedestroyer commented Jan 24, 2020

Command bugs

Command name

payday

What cog is this command from?

Economy

What were you expecting to happen?

For payday to reset when changing the payday time lower to when I last used it.

What actually happened?

Payday should store the last time it was used so it can be compared to the cooldown value rather than using a cooldown deco that won't reset if cooldown goes lower. Thanks @Drapersniper

How can we reproduce this issue?

  1. Set a super high cooldown on payday.
  2. Use payday.
  3. Wait some mins and set cooldown to 5s.
  4. Still in cooldown
@Stonedestroyer Stonedestroyer added the Type: Bug label Jan 24, 2020
@github-actions github-actions bot added the Status: Needs Triage label Jan 24, 2020
@Drapersniper Drapersniper added Status: PRs Welcome Good First Issue and removed Status: Needs Triage labels Jan 24, 2020
@jack1142 jack1142 added the Status: Accepted label Jan 24, 2020
@Hedlund01 Hedlund01 mentioned this issue Feb 3, 2020
Merged
3 tasks
@jack1142 jack1142 added Status: In Progress and removed Good First Issue Status: Accepted Status: PRs Welcome labels Feb 3, 2020
@jack1142 jack1142 linked a pull request Feb 4, 2020 that will close this issue
Payday should store the last time it was used so it can be compared to the cooldown value rather than using a cooldown deco that won't reset if cooldown goes lower #3496
Merged
3 tasks
@jack1142 jack1142 added this to the 3.3.2 milestone Feb 11, 2020
mikeshardmind pushed a commit that referenced this issue Feb 14, 2020
@Hedlund01
Payday should store the last time it was used so it can be compared t…
6ddaff6 
…o the cooldown value rather than using a cooldown deco that won't reset if cooldown goes lower (#3496)

* Payday #3438 Changed next_payday to last_payday

* Created towncrier entry

* [PR #3496] Requested changes

* rm .vs
@mikeshardmind mikeshardmind removed this from the 3.3.2 milestone Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: In Progress Type: Bug
Projects
None yet
Milestone
No milestone
4 participants
@Stonedestroyer @jack1142 @mikeshardmind @Drapersniper