Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloader should check the type of top-level object in info.json #3442

Closed
jack1142 opened this issue Jan 24, 2020 · 1 comment · Fixed by #3533
Closed

Downloader should check the type of top-level object in info.json #3442

jack1142 opened this issue Jan 24, 2020 · 1 comment · Fixed by #3533
Assignees
Labels
Category: Downloader Status: In Progress Type: Bug

Comments

@jack1142
Copy link
Member

jack1142 commented Jan 24, 2020

Other bugs

Example:
info.json like this will make Downloader fail:

[]

We should only allow dicts as top-level objects in info.json

@jack1142 jack1142 added Type: Bug Status: Accepted Category: Downloader Status: PRs Welcome labels Jan 24, 2020
@jack1142 jack1142 changed the title Downloader should check the type of top-level object in json Downloader should check the type of top-level object in info.json Jan 24, 2020
@jack1142 jack1142 added Status: In Progress and removed Status: Accepted Status: PRs Welcome labels Jan 25, 2020
@jack1142 jack1142 self-assigned this Jan 25, 2020
@jack1142 jack1142 added this to the 3.3.1 milestone Jan 27, 2020
@jack1142 jack1142 modified the milestones: 3.3.1, 3.3.2 Feb 4, 2020
@jack1142
Copy link
Member Author

jack1142 commented Feb 4, 2020

Postponing to 3.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Downloader Status: In Progress Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants