Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!announce always sends a message to owners #3513

Closed
trundler-dev opened this issue Feb 6, 2020 · 0 comments · Fixed by #3514
Closed

!announce always sends a message to owners #3513

trundler-dev opened this issue Feb 6, 2020 · 0 comments · Fixed by #3514
Labels
Good First Issue Status: In Progress Type: Bug

Comments

@trundler-dev
Copy link
Contributor

trundler-dev commented Feb 6, 2020

Command bugs

Command name

announce

What cog is this command from?

admin

What were you expecting to happen?

When I use [p]announce , the bot should announce my message without sending me any error.

What actually happened?

When I used [p]announce , the bot announced my message, but also sent me the following error:
I could not announce to the following servers:

How can we reproduce this issue?

  • Start Red and load admin at the latest version.
  • Set up your announcement channel: [p]announceset channel <channel_id>
  • Run an announcement: [p]announce <message>
  • The bot will private message you with the error.

Notes

  • The bug seems to be in this line and below: announce.py line 73. Clearly, the bot should only send the error message to owners if the list failed is not empty.
@trundler-dev trundler-dev added the Type: Bug label Feb 6, 2020
@github-actions github-actions bot added the Status: Needs Triage label Feb 6, 2020
@Drapersniper Drapersniper added Good First Issue Status: Accepted Status: PRs Welcome and removed Status: Needs Triage labels Feb 6, 2020
@Drapersniper Drapersniper added Status: In Progress and removed Status: Accepted Status: PRs Welcome labels Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Status: In Progress Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants