Fix redbot.core.utils.common_filters.INVITE_URL_RE regex
#3717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found that the regex used previously could falsely catch strings such as discord member and discord gggggg which aren't invites and shouldn't be caught, testing with this regex string still catches all invite url variations while allowing these other previously caught strings to keep working
Jackenmen
added
Type: Fix
Category: Core - API - Utils Package
Jackenmen
requested changes
Apr 1, 2020
Jackenmen
requested changes
Apr 1, 2020
Co-Authored-By: jack1142 <6032823+jack1142@users.noreply.github.com>
|
So in looking at this i agreed with your point about not worrying about http/https and or www as if people want a stronger filter based on those they could use retrigger. For discord.io/discord.li they just allow you to create personalized invites, so you give them https://discord.gg/TEeXcDY and you can make discord.io/BB-8 and discord.li redirects to discord.io so they are both the same just different domains |
Jackenmen
approved these changes
Apr 2, 2020
Jackenmen
changed the title
redbot.core.utils.common_filters.INVITE_URL_RE regex
3 tasks
Jackenmen
pushed a commit
that referenced
this pull request
Apr 2, 2020
Jackenmen
added
the
Changelog Entry: Added
Jackenmen
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that the regex used previously could falsely catch strings such as discord member and discord gggggg which aren't invites and shouldn't be caught, testing with this regex string still catches all invite url variations while allowing these other previously caught strings to keep working
Type
Description of the changes
Found that the regex used previously could falsely catch strings such as discord member and discord gggggg which aren't invites and shouldn't be caught, testing with this regex string still catches all invite url variations while allowing these other previously caught strings to keep working