Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropping db in redbot-setup delete #3833

Merged
merged 2 commits into from Apr 5, 2021
Merged

Fix dropping db in redbot-setup delete #3833

merged 2 commits into from Apr 5, 2021

Conversation

Jackenmen
Copy link
Member

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Fixes #3699

@Jackenmen Jackenmen added Type: Fix Category: Core - API - Config This is related to the `redbot.core.config` module and `redbot.core.drivers` package. labels May 7, 2020
@Drapersniper Drapersniper removed their assignment Aug 16, 2020
@Jackenmen Jackenmen modified the milestones: Backlog, 3.4.2 Oct 19, 2020
@Jackenmen Jackenmen modified the milestones: 3.4.4, 3.4.5 Dec 15, 2020
@Jackenmen Jackenmen added the Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. label Jan 20, 2021
@Jackenmen Jackenmen modified the milestones: 3.4.6, 3.4.7 Feb 15, 2021
@Jackenmen Jackenmen modified the milestones: 3.4.9, 3.4.8 Apr 3, 2021
Kowlin
Kowlin approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@Kowlin Kowlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just merge!

@Kowlin Kowlin merged commit 9008410 into Cog-Creators:V3/develop Apr 5, 2021
@Jackenmen Jackenmen deleted the V3/issue_3699 branch April 5, 2021 20:29
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kowlin Kowlin Kowlin approved these changes

@tekulvw tekulvw Awaiting requested review from tekulvw

@Twentysix26 Twentysix26 Awaiting requested review from Twentysix26

Assignees
No one assigned
Labels
Category: Core - API - Config This is related to the `redbot.core.config` module and `redbot.core.drivers` package. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.4.8
Development

Successfully merging this pull request may close these issues.

Can't drop db with redbot-setup delete
3 participants
@Jackenmen @Kowlin @Drapersniper